fix(swift-ios): explain unreachable environments in the new-thread picker - #8621
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
github-actions
Bot
added
vouch:trusted
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9e6ff8e3fa55ff56a1f3eaab97826b9de34ebcbe. Configure here.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR adds unreachable-environment UI and retry actions while changing existing new-task routing and offline project/queue behavior. These production-path behavior changes extend beyond a small isolated fix, so the scope merits human review. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
github-actions
Bot
added
size:XL
saphid
changed the title
Reconnecting is a transient state whose HTTP fallback still serves work, so announcing those environments as unreachable in the picker, empty state, and compose hint contradicted the sidebar and connection hub, which present reconnecting separately from offline. Only disconnected environments are unreachable now. Co-Authored-By: Claude <noreply@anthropic.com>
95d3da6 to
7d2b1ae
Compare
eab37a3
into
pingdotgg:t3code/rebuild-mobile-app-swift
2 participants
The SwiftUI new-thread picker now explains which environments are unreachable and offers Retry. Cached projects remain selectable while offline, so new tasks can enter the durable queue. Disabled environments still reject new tasks.
A connection loss preserves the selected project and its draft key, including when another computer has the same repository. This corrects the earlier change that blocked offline projects and could reset a draft before its pending save completed.
Rebased onto
t3code/rebuild-mobile-app-swiftat614a7b672a. Validation: 115 focused native tests passed on7d2b1ae65885526f51f92040c23781022e2da896. The tests cover the connected-to-offline transition, stable project and draft identity, durable queuing, disabled environments, reachability messages, and Retry state. Range review andgit diff --checkpassed.Original visual evidence
These captures belong to earlier revisions. They were not recaptured for this update.
Original mixed-catalog interaction video
Tracking: native work item 131.
Modernized and fixed with GPT-6 in Codex.